perf: Cache particle hypothesis #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for 5cbdc7dphysmon summary
|
AJPfleger
approved these changes
Apr 28, 2024
|
Note that the CKF speedup is an artifact of the
|
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants. It looks like the `findMass` / `findCharge` calls got more expensive after acts-project#2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants. It looks like the `findMass` / `findCharge` calls got more expensive after acts-project#2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to make these compile time constants if we want to share the constants with
ParticleDatabut we can make them runtime constants.It looks like the
findMass/findChargecalls got more expensive after #2908 but I don't see a reason to optimize them after keeping caching the hypothesis.